search

lijunle / Vsxmd

VS XML documentation -> Markdown syntax.
MIT License
215 stars 51 forks source link

Fixed #72 &lt; and &gt; in comments are not getting replaced with < and > #83

Open Arlodotexe opened 4 years ago

Arlodotexe commented 4 years ago

Title says it all. Tried to follow the current code style as much as possible.

lijunle commented 4 years ago

@Arlodotexe Thanks for contributing this repo! I left some comments in your changes. Besides, could you please give an example the &lt; issue in the test code? So, the generated Markdown file could track that as a test case.

astrohart commented 2 years ago

appveyor is complaining of a warning on line 261 of Extensions.cs. Apparently, there is an extra comma on the second Dictionary element that does not need to be there.

Arlodotexe commented 2 years ago

👋 Seems this slipped under the rug and never resurfaced, until today. Let's get this closed off!

astrohart commented 2 years ago

I cannot figure for the life of me why AppVeyor is complaining.

Arlodotexe commented 2 years ago

could you please give an example the &lt; issue in the test code? So, the generated Markdown file could track that as a test case.

I'm not seeing any test projects where I could supply that. Where should I be looking?

astrohart commented 2 years ago

could you please give an example of the &lt; issue in the test code? So, the generated Markdown file could track that as a test case.

I'm not seeing any test projects where I could supply that. Where should I be looking?

I think what he is asking is, to whip up a little console app or something that has the current version of the Vsxmd NuGet package installed and that has &lt; or < in the XML doc comments of some method, to expose the issue and make it show up in the generated ProjectName.xml file and then he can trace where it shows up in the generated Markdown ProjectName.md file.

Arlodotexe commented 2 years ago

I think what he is asking is, to whip up a little console app or something that has the current version of the Vsxmd NuGet package installed and that has &lt; or < in the XML doc comments of some method, to expose the issue and make it show up in the generated ProjectName.xml file and then he can trace where it shows up in the generated Markdown ProjectName.md file.

That seems a little unorthodox, if I'm going to write a test I would want to use it as repeatable proof that things are working as expected.

I'll wait for a maintainer response on this.