lijx10 / DeepI2P

DeepI2P: Image-to-Point Cloud Registration via Deep Classification. CVPR 2021
MIT License
219 stars 36 forks source link

Enquiry for kitti dataloader file,line 296 #13

Closed martin-liao closed 2 years ago

martin-liao commented 2 years ago

In kitti_pc_img_pose_loader.py file,line 296,the transformation matrix was written as: Pc = np.dot(self.calib_helper.get_matrix(seq, img_key), self.calib_helper.get_matrix(seq, 'Tr')) In my view,this matrix only works in function "search_for_accumulation". To transform pcs from timestamp j to timestamp i ,it is a little strange to :

  1. transforming pcs into camera 0
  2. translation from camera 0 to camera i
  3. pose transforming.
  4. ... Although camera i is parallel to camera 0 so there is no problem in your code,why not just throw away the translation step(2)? It is confusing...