likaiguo / svg-edit

Automatically exported from code.google.com/p/svg-edit
MIT License
0 stars 0 forks source link

Switch order of Rectangle and Ellipse toolbox #179

Closed GoogleCodeExporter closed 9 years ago

GoogleCodeExporter commented 9 years ago
What steps will reproduce the problem?
1. Hold down on Rect icon
2. Select the rectangle one (not the square)
3. Look at the rect icon (it's now a rectangle)
4. Switch to Select tool
5. Click on the rect icon

What is the expected output? What do you see instead?
It should change the tool to the rectangle, but it actually changes to the 
square.

Original issue reported on code.google.com by Antimatter15 on 5 Sep 2009 at 1:04

GoogleCodeExporter commented 9 years ago
This is because the 'rect' icon is really a flyout menu and by clicking that 
icon,
you are selecting the first item in the flyout menu (the Square).

I don't really want to change the flyout menu mechanism (I think it's fine), 
but I
would agree with the idea of putting Rect and Ellipse first in the flyout 
menus. 
This would also line up with having '4' be the Rect and Shift-4 be the Square.

Original comment by codedr...@gmail.com on 5 Sep 2009 at 7:28

GoogleCodeExporter commented 9 years ago
What do people think about switching the order of rect/square in the flyout 
menu so
that Rect is the default?

What do people think about switching the order of ellipse/circle in the flyout 
menu
so that Ellipse is the default?

Original comment by codedr...@gmail.com on 23 Oct 2009 at 6:27

GoogleCodeExporter commented 9 years ago

Original comment by codedr...@gmail.com on 23 Oct 2009 at 6:28

GoogleCodeExporter commented 9 years ago
Sounds good to me.

In fact... (and many will probably disagree with me here) as far as I'M 
concerned, I
wouldn't mind if we did away with the "square", "circle", "freehand rectangle" 
and
"freehand ellipse" options all together. 

Here's why: Squares and circles can technically be created by holding shift (as 
soon
as Issue 88 has been fixed). The freehand varieties (while I think technically 
are
really neat and awesome) ultimately don't seem all that useful to me. That's 
just my
opinion, so I'd love to hear from some actual users how often they find 
themselves
using these tools. 

Anyway, I don't really mind them staying, I'd just like to make sure they really
deserve to be part of an interface that in the future will likely contain 
options
that are actually more useful.

Original comment by adeve...@gmail.com on 23 Oct 2009 at 7:53

GoogleCodeExporter commented 9 years ago
here i agree with adeveria. never have used freehand tool and it seems a 
"sloppy"
method since the designer does not benefit form a pre-drawing. also after Issue 
88 is
solved, the designer will have a comprehensive method to keep same ratio (i 
hope for
svg groups, raster images, svg objects in general). it will also flatten the 
UI, and
that is good.

Original comment by Christia...@gmail.com on 4 Nov 2009 at 8:45

GoogleCodeExporter commented 9 years ago
I'm also not a fan of the free-hand ellipse/rect tools.  However, I know some 
people
are partial to them.

I would suggest we leave things around until at least 2.5 where we'll do some 
more UI
cleanup.

Original comment by codedr...@gmail.com on 4 Nov 2009 at 9:55

GoogleCodeExporter commented 9 years ago
I don't mind changing the flyouts to have the rectangle and the ellipse as the 
first
choice, personally. 

But I do think having premade squares and circles is good, I use them quite a 
lot
actually (e.g. to draw icons). Of course, fixing issue 88 would also be great
(Inkscape parity).

As for the freehand tools, I am in favour of keeping them as well. I think they 
can
be fun to use by some people (children), or when you lack inspiration and just
"sketch". Flyout menus are just good for that, they don't take real estate in 
the UI,
they are for options that you give to the users.

As far as I am concerned, the more features/options, the better!

Original comment by worms_...@yahoo.com on 4 Nov 2009 at 10:28

GoogleCodeExporter commented 9 years ago
Since there have been no objections, I have made this change in r927.

Original comment by adeve...@gmail.com on 10 Nov 2009 at 7:17