likeabowx / pe

0 stars 0 forks source link

Wrong display format for large ingredient's quantity #6

Open likeabowx opened 2 years ago

likeabowx commented 2 years ago

When using a large number for the ingredient's quantity, the number displayed is in a weir format (not the whole number itself). There is no mention of any restrictions (integer or max value) for the ingredient's quantity field anywhere.

Large quantity for meat: image.png

nus-pe-bot commented 2 years ago

Team's Response

You are right that there is no max value restriction stated in the UG for the quantity field for ingredients. That is because that is true, our team has decided to not limit the quantity that a user can specify for an ingredient due to being unaware of the quantifier (i.e an upper-bound of 1000 for kg might make sense but does not make sense for ml)

That being said, the displayed result is valid and correct being represented in scientific notation for brevity.

Thus our team has concluded that the main issue at hand is that the user is unaware that there will be a change in number format representation for very large numbers (arguably unreasonably large). And this is caused by a lack of documentation in the UG. The fix to this would be to document in our UG that this change of format would occur for large numbers.

Therefore, we have decided that this is a documentation bug and should have a severity of low due to the fact that it is unlikely to affect normal operations of the product (Such large quantities are rare). Appears only in very rare situations and causes a minor inconvenience only (Values are correct just in a different format).

Items for the Tester to Verify

:question: Issue type

Team chose [type.DocumentationBug] Originally [type.FunctionalityBug]

Reason for disagreement: [replace this with your explanation]


:question: Issue severity

Team chose [severity.Low] Originally [severity.Medium]

Reason for disagreement: [replace this with your explanation]