likeastore / ngDialog

Modals and popups provider for Angular.js applications
http://likeastore.github.io/ngDialog
3.14k stars 692 forks source link

Protractor issue with Chrome #495

Open ghost opened 8 years ago

ghost commented 8 years ago

What version of ng-dialog are you using? v0.6.2

What version of AngularJS are you using? v1.5.5

What browsers are affected? Chrome (maybe others)

Please describe the issue ngDialog opened, but after that, nothing happens. I set browser.pause() on protractor, after opening a dialog, and then I'm trying to close it (but I can't). dialog seems freezed, clicking on overlay doesn't work too, or anything else like pressing escape.

There was already an issue for this : https://github.com/likeastore/ngDialog/issues/346 Did you plan to fix it ? or any solution at all ? because my test need to work on Chrome, and not only on Firefox.

Thx in advance.

SOLUTION :

var disableNgDialogAnim = function () {
    angular.module("disableNgDialogAnim", [])
        .config(["ngDialogProvider",
            function (ngDialogProvider) {
                ngDialogProvider.setDefaults({
                    disableAnimation: true
                });
            }]);
        };

browser.addMockModule("disableNgDialogAnim", disableNgDialogAnim);
codingsteff commented 8 years ago

or disable animations in protractor.conf.js

in the onPrepare() function:

var disableNgDialogAnimate = function () {
      angular.module('disableNgDialogAnimate', []).config(['ngDialogProvider', function (ngDialogProvider) {
        ngDialogProvider.setDefaults({
          disableAnimation: true
        });
      }]);
    };
browser.addMockModule('disableNgDialogAnimate', disableNgDialogAnimate);
ghost commented 8 years ago

Yes we found that solution with vbourgeois ... but we forgot to edit our post. Thx for you help.