request: add onBeforeOpen function

likeastore / ngDialog

Modals and popups provider for Angular.js applications

http://likeastore.github.io/ngDialog

3.14k stars 692 forks source link

request: add onBeforeOpen function #509

Closed mattiLeBlanc closed 7 years ago

mattiLeBlanc commented 8 years ago

Hi,

Would you agree it would be nice to add an onBeforeOpen function to the dialog.open() function so that I can do some dom manipulation just after the the modal has been added to the DOM but not yet visible. The only way now catching the event 'ngDialog.opened' on $rootScope. But I don't want to use any scope (angular 2 ready?).

ashubham commented 7 years ago

@mattiLeBlanc Do you happen to have any fork where you tried implementing this. events and scope are ugly.

mattiLeBlanc commented 7 years ago

ouch, it has been a while so I have to remember where I needed this option. I might have found a way around this. Let me come back to you on this, kay?

faceleg commented 7 years ago

Moving conversation to the PR