likeastore / ngDialog

Modals and popups provider for Angular.js applications
http://likeastore.github.io/ngDialog
3.14k stars 692 forks source link

Please update alone with Angular 1.6.0 #528

Closed reevelau closed 7 years ago

reevelau commented 7 years ago

Angular 1.6.0 has been release on 8-Dec. So far no noticeable issue was found when using ngDialog. Release Notes

But just bower install reports conflict when executing.

What version of ng-dialog are you using? 0.6.4

What version of AngularJS are you using? 1.6.0

What browsers are affected? no obvious issue

Please provide either a JSFiddle, Plunkr example that replicates the issue

Please describe the issue bower install reports conflict

But I can workaround the prompt with this bower configuration "resolutions" :{ "angular": "~1.6.0" }

What did you expect to happen? no

What actually happened?

faceleg commented 7 years ago

Please submit a PR with this change, I'll merge it

reevelau commented 7 years ago

I can do that, but could you briefly tell me the dev environment requirements? like how to run the tests? how many tests? Thanks!!!

faceleg commented 7 years ago

Done - https://github.com/likeastore/ngDialog/tree/v0.6.6