changes close element to button with proper accessibility rules (Fixes Issue #511)

likeastore / ngDialog

Modals and popups provider for Angular.js applications

http://likeastore.github.io/ngDialog

3.14k stars 692 forks source link

Closed timjenkins closed 7 years ago

timjenkins commented 7 years ago

The close button is not appearing on screen readers because it is not marked up as an interactable element.

element changed to button
aria-label set to "Dismiss" to avoid confusion with closing the tab, browser, or whole page.
css rules added to remove default browser styling of button elements

This contribution is provided under the MIT License.

faceleg commented 7 years ago

Thanks, appreciate it

timjenkins commented 7 years ago

@faceleg thanks! any idea how long it will take to get this into a release?

faceleg commented 7 years ago

Done