fix for Scrollbars not clickable on overflow

likeastore / ngDialog

Modals and popups provider for Angular.js applications

http://likeastore.github.io/ngDialog

3.14k stars 692 forks source link

fix for Scrollbars not clickable on overflow #553

Closed dpicode closed 7 years ago

dpicode commented 7 years ago

Make ngdialog-overlay background transparent and pass this background opacity to ngdialog. ngdialog-overlay have now a 15px margin-right to allow clickeable scrollbar.

-- Regards, www.dpicode.com

What issue is this PR resolving? Alternatively, please describe the bugfix/enhancement this PR aims to provide

Have you provided unit tests that either prove the bugfix or cover the enhancement?

Related issues

faceleg commented 7 years ago

Thank you :)

dmitry-zaets commented 7 years ago

Looks like it was merged but it's not present in master anymore. Do you still plan to land it into master?

fhurta commented 7 years ago

The problem of this fix is that the edited file is output of the build. You should have edited file css\myth\ngDialog.css and not directly css\ngDialog.css (which is generated by build scripts).

I'm just preparing my own PR and did the same mistake, only after I reviewed the gruntfile I noticed the myth subfolder. Aftre the build process I found changes in ngDialog.css, which I haven't touched.