search

likeastore / ngDialog

Modals and popups provider for Angular.js applications
http://likeastore.github.io/ngDialog
3.14k stars 692 forks source link

fix for Scrollbars not clickable on overflow #555

Closed dpicode closed 7 years ago

dpicode commented 7 years ago

Make ngdialog-overlay background transparent and pass this background opacity to ngdialog. ngdialog-overlay have now a 15px margin-right to allow clickeable scrollbar.

-- Regards, www.dpicode.com

What issue is this PR resolving? Alternatively, please describe the bugfix/enhancement this PR aims to provide

Have you provided unit tests that either prove the bugfix or cover the enhancement?

Related issues

dmitry-zaets commented 7 years ago

Closing #521

dmitry-zaets commented 7 years ago

This fix is causing an inconsistent UI animation behavior because the layers get animated with different timings. If you will check the examples you will be able to see that first the modal window disappears and then the background, but expected behavior is that both disappears at the same time.

Reproducible here: https://github.com/likeastore/ngDialog/blob/master/example/index.html Expected behavior: http://likeastore.github.io/ngDialog/

burdell commented 7 years ago

Can somebody make a new release that has this included in it?

dmitry-zaets commented 7 years ago

It is included, but the fix breaks the animation