search

likeastore / ngDialog

Modals and popups provider for Angular.js applications
http://likeastore.github.io/ngDialog
3.14k stars 692 forks source link

Override default template for close button #560

Closed mrsidde closed 4 years ago

mrsidde commented 7 years ago

Hi! Im trying change the default value/markup of the close button <button aria-label="Dismiss" class="ngdialog-close"></button>

My plan is to use a svg, something like this: <svg class="ngdialog-close > <ellipse class="custom-close" .../> <path class="" .../> </svg>

Any idea how or if it's possible in the current version?

Thanks in advance! 👍

ghost commented 7 years ago

while testing with JAWS for accessibility, the close/ dismiss button is not navigable by keyboard, on adding character within the button, it becomes navigable by keyboard. i'm assuming   would work as well, alternatively, adding tabindex=0 might work too. but in order to try it out, we need a way to customize it.

can this be taken up as priority?