search

likeastore / ngDialog

Modals and popups provider for Angular.js applications
http://likeastore.github.io/ngDialog
3.14k stars 692 forks source link

Close button looks and behave strange across broswers #563

Closed fhurta closed 7 years ago

fhurta commented 7 years ago

I used ngDialog in my app and noticed strange look of the close button in Chrome. When trying in FF and IE11, it looks differently and in FF the click on the cross does not work at all (only clicking on the very small button itself).

I compared it to your Demo where it looks and works well. In the end I've noticed that while in the Demo the close button is rendered as <div>, in my case it is rendered as <button>. When I changed the element in browser dev tools to <div> it worked fine in all 3 tested browsers.

I open the dialog using ngDialog.open() method.

ngDialog 1.3.0 angularJs 1.6.5 browsers tested: Chrome current, FF current, IE 11 Test at: https://codepen.io/exavier/full/NvqOgB/

fhurta commented 7 years ago

Seems #533 is the source of problems