search

likeastore / ngDialog

Modals and popups provider for Angular.js applications
http://likeastore.github.io/ngDialog
3.14k stars 692 forks source link

Fix styles for close button #564

Closed fhurta closed 7 years ago

fhurta commented 7 years ago

What issue is this PR resolving?

Fixes look and behavior of the dialog's close button (after it has been changed from <div> to <button>. It works now in other browsers (tested Chrome, Firefox, IE11). Fix #563, Fix #556

PR changes styles of the close <button> and its ::after pseudo class in themes default and plain.

Related issues

511 #533

Note: after build I noticed that also ngDialog.css is changed - I figured out that it is because #553 committed the changes directly to css/ngDialog.css and not to css/myth/ngDialog.css (I left my comment at the PR). I didn't commit css/ngDialog.css into this PR to not affect the current functionality (but it should be fixed by some other PR to not loose the changes by other PRs).

fhurta commented 7 years ago

To compare and test you can use following CodePens:

Dialog with original v1.3.0 styles

Dialog with fixed styles

faceleg commented 7 years ago

Thanks :)