likeastore / ngDialog

Modals and popups provider for Angular.js applications
http://likeastore.github.io/ngDialog
3.14k stars 692 forks source link

grunt build issue #573

Closed night-fury-web closed 6 years ago

night-fury-web commented 6 years ago

What version of ng-dialog are you using? 1.4.0 What version of AngularJS are you using? 1.5.11 What browsers are affected? Chrome 60.0.3112.113

Please describe the issue I use ngDialog for project in angular 1.5.x and grunt for bundling static files. After concatenating and uglifying all js files, ngDialog.openconfirm() shows error, though ngDialog.open() works.

Without minification, openconfirm also works. Please help me to fix this issue.

night-fury-web commented 6 years ago

Fixed issue by changing following code

ngDialog.openConfirm({
    template: "static/templates/modal/simpleInput.html",
    controller: function ($scope) {
        $scope.popupTitle = 'Input Code';
    },
    scope: $scope
})

to

ngDialog.openConfirm({
    template: "static/templates/modal/simpleInput.html",
    controller: ['$scope', function ($scope) {
        $scope.popupTitle = 'Input Code';
    }]
})