search

likeastore / ngDialog

Modals and popups provider for Angular.js applications
http://likeastore.github.io/ngDialog
3.14k stars 692 forks source link

Setting a controller doesn't work with angular 1.7.1 #591

Closed daviferreira closed 6 years ago

daviferreira commented 6 years ago

What version of ng-dialog are you using? 1.4.0

What version of AngularJS are you using? 1.7.1

What browsers are affected? All

Please describe the issue The "later" param was removed from $controller (https://github.com/angular/angular.js/pull/16580). It was a private api and is being used here: https://github.com/likeastore/ngDialog/blob/master/js/ngDialog.js#L651

Reference: https://github.com/angular/angular.js/issues/16594

daviferreira commented 6 years ago

Seems like the angular team will revert that change in 1.7.2: https://github.com/angular/angular.js/issues/16594