AngularJs 1.7, on every route change the dialogs are incrementing. every time you come back to the controller the dialogs will be 1,2,3,4 and so on

GitSahib commented 5 years ago

What version of ng-dialog are you using?

What version of AngularJS are you using?

What browsers are affected?

Please provide either a JSFiddle, Plunkr example that replicates the issue

Please describe the issue

What did you expect to happen?

What actually happened?

SirDaev commented 5 years ago

This seems to be the default, intended behavior. If you need to select a specific modal with CSS or JS, there are the options to use a custom classname: className and appendClassName.

GitSahib commented 5 years ago

But why is it creating more than one dialog. The problem is not the I'd it's the number of dialogs are increasing

On Wed, Jan 9, 2019, 12:39 PM Dave Judd <notifications@github.com wrote:

This seems to be the default, intended behavior. If you need to select a specific modal with CSS or JS, there are the options to use a custom classname: className and appendClassName.

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/likeastore/ngDialog/issues/595#issuecomment-452782764, or mute the thread https://github.com/notifications/unsubscribe-auth/AQavoigXlBjHEysQq0q6yd4pfY28LpPFks5vBiltgaJpZM4Zl0TX .

SirDaev commented 5 years ago

Are multiple modals opening (+1 each time) when coming back to the controller?

GitSahib commented 5 years ago

Exactly

Sent from my Samsung Galaxy smartphone. -------- Original message --------From: Dave Judd notifications@github.com Date: 1/9/19 1:08 PM (GMT-05:00) To: likeastore/ngDialog ngDialog@noreply.github.com Cc: Sahib Zar Khan sahib.zer@gmail.com, Author author@noreply.github.com Subject: Re: [likeastore/ngDialog] AngularJs 1.7, on every route change the dialogs are incrementing. every time you come back to the controller the dialogs will be 1,2,3,4 and so on (#595) Are multiple modals opening (+1 each time) when coming back to the controller?

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub, or mute the thread. {"api_version":"1.0","publisher":{"api_key":"05dde50f1d1a384dd78767c55493e4bb","name":"GitHub"},"entity":{"external_key":"github/likeastore/ngDialog","title":"likeastore/ngDialog","subtitle":"GitHub repository","main_image_url":"https://github.githubassets.com/images/email/message_cards/header.png","avatar_image_url":"https://github.githubassets.com/images/email/message_cards/avatar.png","action":{"name":"Open in GitHub","url":"https://github.com/likeastore/ngDialog"}},"updates":{"snippets":[{"icon":"PERSON","message":"@SirDaev in #595: Are multiple modals opening (+1 each time) when coming back to the controller?"}],"action":{"name":"View Issue","url":"https://github.com/likeastore/ngDialog/issues/595#issuecomment-452790308"}}} [ { "@context": "http://schema.org", "@type": "EmailMessage", "potentialAction": { "@type": "ViewAction", "target": "https://github.com/likeastore/ngDialog/issues/595#issuecomment-452790308", "url": "https://github.com/likeastore/ngDialog/issues/595#issuecomment-452790308", "name": "View Issue" }, "description": "View this Issue on GitHub", "publisher": { "@type": "Organization", "name": "GitHub", "url": "https://github.com" } } ]

likeastore / ngDialog

AngularJs 1.7, on every route change the dialogs are incrementing. every time you come back to the controller the dialogs will be 1,2,3,4 and so on #595