search

likebike / fasteval

Fast and safe evaluation of algebraic expressions
https://crates.io/crates/fasteval/
MIT License
267 stars 26 forks source link

Rust can parse Very Long nine tails since 1.55.0 #17

Open nabijaczleweli opened 2 years ago

nabijaczleweli commented 2 years ago

False negative in the test, nbd

keszybz commented 2 years ago

I think should be conditionalized on rust version. With rust 1.54.0 this test now fails.

nabijaczleweli commented 2 years ago

Yeah, fair. cfg(version) is experimental, so I effectively inlined the rustc_version crate, and pick the old path before rustc 1.55

keszybz commented 2 years ago

I tested this with rust-1.54.0-1.fc33.x86_64 and cargo-1.56.1-1.fc33.x86_64 and the tests pass in both cases.