search

likebike / fasteval

Fast and safe evaluation of algebraic expressions
https://crates.io/crates/fasteval/
MIT License
275 stars 27 forks source link

Reword --emit=asm advice #8

Closed lnicola closed 4 years ago

lnicola commented 4 years ago

While it's true that codegen-units=1 will usually improve code generation, that's often application-specific and will slow down the compilation even more. It's a compromise, and it's unfair to tell users to always do that. It would have been the default if that was true.

In any case, --emit=asm isn't really good advice.

likebike commented 4 years ago

Thank you @lnicola , I will pull this when I get some time.

likebike commented 4 years ago

Thank you again @lnicola , and I apologize for the extreme delay pulling in this change. I moved countries, got a new job, and was dealing with some medical issues, so I was preoccupied and unable to spend any time on this. I am hoping to have a more stable life going forward.

Best Regards!

lnicola commented 4 years ago

No worries, I doubt anyone missed that clarification. I hope everything works out fine for you. Good luck and stay healthy!