codepathreview
commented
9 years ago :+1: Project looks good, glad you were able to finish all required stories
- Good to see you properly communicated the user to the user timeline fragment from the profile activity.
- Nice to see you used the ViewPager to properly setup the tabs!
- Good to see you played with styling
- The main learning for this assignment was to learn how to architect such apps. Architecting the fragments (base class and extension classes) should be done such that you put as much code and logic as possible in the base class and then used abstract methods to define only the specific behavior where they differ. Your code is a big dump of if-else conditions, which is not reusable and hard to maintain.
- Consider adding progress bars to your app whenever a network request goes out
- Try to implement more optional features so that you will get to play with more widgets and understand complexities involved I have provided a detailed Project 4 Feedback Guide here which covers the most common issues with this submitted project. Read through the feedback guide point-by-point to determine how you might be able to improve your submission.
Let us know if you have any other thoughts or questions about this assignment. Hopefully you can see this coming together as a "fully fledged" twitter client with some more work and polish. This app contains all of the components now (fragments, models, networking, client, tab navigation, image loading, et al) of 90% of dynamic data-driven API client. Obviously there are lots of details and patterns to learn, but by this point you have been introduced to all the major frameworks and concepts. Hopefully you would feel fairly confident getting started making Android apps for instagram, pinterest, yardsale, flickr using the same patterns.
My app is complete, please review. Thanks. /cc @nidhi1608 @thecodepath