likle / cwalk

Path library for C/C++. Cross-Platform for Linux, FreeBSD, Windows and MacOS. Supports UNIX and Windows path styles on those platforms.

https://likle.github.io/cwalk/

MIT License

250 stars 39 forks source link

added new build option, IGNORE_WARNINGS #22

Closed falsycat closed 3 years ago

falsycat commented 3 years ago

I added new CMake option, IGNORE_WARNINGS, because build failed in MSVC in GitHub Actions since a warning below.

2021-05-30T03:48:22.7629665Z C:\Program Files (x86)\Windows Kits\10\Include\10.0.17763.0\ucrt\ctype.h(241,5): error C2220: the following warning is treated as an error [D:\tmp\upd\Debug\thirdparty\cwalk\cwalk.vcxproj]
2021-05-30T03:48:22.7632413Z C:\Program Files (x86)\Windows Kits\10\Include\10.0.17763.0\ucrt\ctype.h(241,5): warning C5105: macro expansion producing 'defined' has undefined behavior [D:\tmp\upd\Debug\thirdparty\cwalk\cwalk.vcxproj]

codecov[bot] commented 3 years ago

Codecov Report

Merging #22 (b52ab26) into master (d418a2e) will not change coverage. The diff coverage is n/a.

@@           Coverage Diff           @@
##           master      #22   +/-   ##
=======================================
  Coverage   98.14%   98.14%           
=======================================
  Files           1        1           
  Lines         485      485           
=======================================
  Hits          476      476           
  Misses          9        9

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update d418a2e...b52ab26. Read the comment docs.

likle commented 3 years ago

Hi @falsycat ! Thank you very much for your valuable contribution. I think I have seen a similar warning before, changing the Windows SDK version might help you as well to get rid of it.