Closed Jules-L closed 1 year ago
Merging #35 (afaf691) into master (d92d846) will not change coverage. The diff coverage is
n/a
.
@@ Coverage Diff @@
## master #35 +/- ##
=======================================
Coverage 98.00% 98.00%
=======================================
Files 1 1
Lines 502 502
=======================================
Hits 492 492
Misses 10 10
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.
Hi @Jules-L , thank you so much for your pull requests! It is really appreciated.
I wasn't entirely sure about the separate version file as I haven't seen this method widely spread. But pragmatically it makes sense and I haven't seen any issues so far, so I will merge this and we will see how it goes 🙂
Description
I use
cwalk
as a subproject and I kept getting 2 warnings from Meson in my top level project:include_directories
is a newer feature than the min supported meson version (>=0.45.1
):meson.build:15: WARNING: Project targets '>= 0.45.1' but uses feature introduced in '0.50.0': include_directories kwarg of type string. Use include_directories('include') instead
project()
Changes
How Has This Been Tested?
Built from source using both meson and CMake: -
meson setup meson_build && meson compile -C meson_build
-mkdir cmake_build && cd cmake_build && cmake .. && make
Seemed to work fine for both. Ran the test suite successfully on the
cmake_build
.