meson: fix symbol exporting on simultaneous static and shared building

likle / cwalk

Path library for C/C++. Cross-Platform for Linux, FreeBSD, Windows and MacOS. Supports UNIX and Windows path styles on those platforms.

https://likle.github.io/cwalk/

MIT License

253 stars 40 forks source link

Open antoniovazquezblanco opened 6 months ago

antoniovazquezblanco commented 6 months ago

It turns out https://github.com/likle/cwalk/pull/46 was not the best solution.

default_library is a tri-state. When both libraries are being built, it is important to also set the exported flag.

likle commented 6 months ago

Hi @antoniovazquezblanco ! I am not verify familiar with meson, doesn't "both" mean it builds shared as well as static?

Wouldn't that set it to CWK_SHARED for the static build done using the both option?

antoniovazquezblanco commented 6 months ago

Let's move the conversation to https://github.com/mesonbuild/wrapdb/pull/1387, those guys know more than me :D