search

lil-lab / recnet

A human-driven recommendation system for academic readings.
https://recnet.io
MIT License
4 stars 1 forks source link

Recommendation appearing on profile before cutoff #249

Closed yoavartzi closed 2 months ago

yoavartzi commented 3 months ago

I see a recommendation appearing on my profile page before cutoff. I don't think this happened before, but not sure what changed recently. One thing that distinguishes this rec is that the paper was already known to the system, so it filled all the details automatically.

image image
swh00tw commented 3 months ago

Yeah this might be a bug. I guess it's that the logic in profile page didn't filter out the upcoming rec, it just simply shows all your past recs in DB. I think this API need a fix. (I can filter out the upcoming rec in FE, but I think fix it in API side will make more sense.)


  @ApiOperation({
    summary: "Get recs",
    description: "Get historical recs by userId with pagination.",
  })
  @ApiOkResponse({ type: GetRecsResponse })
  @ApiBearerAuth()
  @Get()
  @UsePipes(new ZodValidationQueryPipe(getRecsParamsSchema))
  public async getRecs(@Query() dto: QueryRecsDto): Promise<GetRecsResponse> {
    const { page, pageSize, userId } = dto;
    return this.recService.getRecs(page, pageSize, userId);
  }

cc @joannechen1223

yoavartzi commented 3 months ago

So let's fix it properly on the API side. Can definitely wait for next week when you two are back.

On Tue, Aug 20, 2024 at 10:34 PM Shu-Wei Hsu @.***> wrote:

Yeah this might be a bug. I guess it's that the logic in profile page didn't filter out the upcoming rec, it just simply shows all your past recs in DB. I think this API need a fix. (I can filter out the upcoming rec in FE, but I think fix it in API side will make more sense.)

@ApiOperation({ summary: "Get recs", description: "Get historical recs by userId with pagination.", }) @ApiOkResponse({ type: GetRecsResponse }) @ApiBearerAuth() @Get() @UsePipes(new ZodValidationQueryPipe(getRecsParamsSchema)) public async @.***() dto: QueryRecsDto): Promise { const { page, pageSize, userId } = dto; return this.recService.getRecs(page, pageSize, userId); }

cc @joannechen1223 https://github.com/joannechen1223

— Reply to this email directly, view it on GitHub https://github.com/lil-lab/recnet/issues/249#issuecomment-2300341070, or unsubscribe https://github.com/notifications/unsubscribe-auth/AAZDGEKMWH73XRZK7UZNBUTZSP4B3AVCNFSM6AAAAABM2TE2O6VHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDGMBQGM2DCMBXGA . You are receiving this because you authored the thread.Message ID: @.***>

joannechen1223 commented 2 months ago

Fixed in v1.3.3