search

lilHermit / cakephp-plugins-bootstrap4

3 stars 5 forks source link

columType is deprecated #6

Closed tgoeminne closed 5 years ago

tgoeminne commented 6 years ago

some of the function is raising deprecated errors.

lilHermit commented 5 years ago

Hi thank-you for taking the time to submit this PR, sorry it's taken so long to get back to you.

We might need a version check/if so we don't break backwards compatibility. Perhaps a wrapper method?

lilHermit commented 5 years ago

@tgoeminne Can you test master to see if that commit fixes your issue? I'll push 4003 soon.

johnneijzen commented 5 years ago

this broke cakephp 3.7 bake for me i think this is because of columns() - Get the column names in the table. and getColumn() - Get column data in the table.

lilHermit commented 5 years ago

@johnneijzen if you want to test dev-master this should be fix, I'll push a full release shortly. once we are happy