lilab-bcb / altocumulus

Command line tool for submitting WDL jobs to Terra or Cromwell server.
https://altocumulus.readthedocs.io
BSD 3-Clause "New" or "Revised" License
7 stars 0 forks source link

Bug fix on sample sheet uploading #30

Closed yihming closed 2 years ago

yihming commented 2 years ago

Issue

Altocumulus tries to upload BCL folders or FASTQ files before checking if the provided path is a Cloud URI or a local path. It brings problems, because Python's os.path.abspath("gs://bucket-name/folder-name") returns the following string:

/path/to/local/cwd/gs://bucket-name/folder-name

and thus the sample sheet uploading fails.

Solution

I reorganize the checking on path at the BCL/FASTQ step to include the checking on if it is a Cloud URI (only consider S3 and GS URIs for now). And if encountering a Cloud URI, simply skip the rest of process and go to the next path.