lilab-bcb / cirrocumulus

Bring your single-cell data to life
https://cirrocumulus.readthedocs.io/
BSD 3-Clause "New" or "Revised" License
75 stars 16 forks source link

Add browse dataset option #216

Open danielquintao opened 1 month ago

danielquintao commented 1 month ago

This Pull Request aims at providing an alternative experience for addind a new dataset in the server mode (cirro serve) when the server machine has a directory where datasets must be browsed from.

Precisely, by providing the option --datadir <some directory> to cirro serve, the text input "URL" is replaced by a select input with the valid datasets within <some directory> (whether they are first children or not; I used os.walk to find all interesting datasets, which can be files or specialy formatted directories such as .zarr ones). The UI looks like this with the new option:

image

I didn't have to change many files to do so, and both my manuel tests and the existing pytest tests passed. However, I have two important comments:

danielquintao commented 3 weeks ago

Hello!

Are there any news concerning the revision of this PR? Please do not hesitate in telling me if there are any needed fixes. I hope you find the new feature carried by the PR useful.

Regards