Integrating MPS backend

lilab-bcb / harmony-pytorch

BSD 3-Clause "New" or "Revised" License

46 stars 9 forks source link

Integrating MPS backend #9

Closed mbruhns closed 6 months ago

mbruhns commented 7 months ago

Hi,

thanks for providing this nice Pytorch implementation of Harmony. I slightly adapted the code to make it usable on Apple Silicon. I also updated the requirements to make sure that a suitable Pytorch version is installed. The additional changes are due to reformatting with Ruff and Sourcery. Please let me know if I should adapt anything.

yihming commented 7 months ago

Hi @mbruhns . Thank you very much for your contribution to improving this software. The main part looks good to me. I've left my comments on some minor changes in the review. Please feel free to let me know what you think.

Sincerely, Yiming

mbruhns commented 7 months ago

Hi @yihming, what do you think about the changes?