search

lilactown / helix

A simple, easy to use library for React development in ClojureScript.
Eclipse Public License 2.0
624 stars 52 forks source link

replace goboj/extend with js/Object.assign (fix #112) #113

Closed shaunlebron closed 1 year ago

shaunlebron commented 1 year ago

Fixes #112

The nil check can be removed with Object.assign. (See spec step 3a)

And the nil check is covered by this test: https://github.com/lilactown/helix/blob/c35fe1885f45786a82602b1c7ec038022423dadc/test/helix/impl/props_test.cljc#L152-L154

lilactown commented 1 year ago

Fantastic! Thanks for the contribution