search

lilactown / helix

A simple, easy to use library for React development in ClojureScript.
Eclipse Public License 2.0
624 stars 52 forks source link

`wrap-fx` is public #127

Closed SevereOverfl0w closed 1 year ago

SevereOverfl0w commented 1 year ago

https://github.com/lilactown/helix/blob/cc88c8ccfd73fa8e4ac803dd2dcf9115ac943a89/src/helix/hooks.cljc#L122-L129

Is this intentional? It has no docstring, and I think it's only supposed to be for internal use by use-effect

lilactown commented 1 year ago

not really. if we make it ~public~ private, will the macroexpansion of use-effect cause compiler warnings?