lilactown / helix

A simple, easy to use library for React development in ClojureScript.
Eclipse Public License 2.0
624 stars 52 forks source link

Use the modern JSX transform (closes #123) #129

Closed rome-user closed 1 year ago

rome-user commented 1 year ago

With the new transform, the $ macro is technically no longer dependent on React. This possibly opens a path to Preact support in Helix.

More importantly, we obtain marginally faster performance. React is able to make optimizations that it otherwise can't with React.createElement().


Backwards compatibility While the new JSX transform was introduced in React 17, it has been backported to React 16.14.0, React 15.7.0, and React 0.14.10. This PR should not introduce any surprises to current users of Helix, unless they use outdated versions of React 16, 15, or 0.14.

Pros

Cons

lilactown commented 1 year ago

I'll review this week. Thank you so much!

lilactown commented 1 year ago

Still on my list. @rome-user could you resolve the conflicts on this branch?

rome-user commented 1 year ago

Sure. I'll be able to do that over the next few days