search

lilactown / helix

A simple, easy to use library for React development in ClojureScript.
Eclipse Public License 2.0
627 stars 52 forks source link

Generate internal defnc components with ^:private metac #65

Closed SevereOverfl0w closed 3 years ago

SevereOverfl0w commented 4 years ago

When completing you get both -render-type and -item-render-type for the component. I think these should be private instead, thoughts?

lilactown commented 4 years ago

That makes sense to me. This is only when using factory functions, and you should be able to use helix.core/type to get the render fn from the factory fn if needed.

SevereOverfl0w commented 4 years ago

That's so useful, I've been breaking the rules then!

lilactown commented 4 years ago

Undocumented code might as well not exist 😝