search

lilactown / helix

A simple, easy to use library for React development in ClojureScript.
Eclipse Public License 2.0
627 stars 52 forks source link

only convert cljs map to object in native style prop vector #68

Closed alidcast closed 4 years ago

alidcast commented 4 years ago

fixes #67

alidcast commented 4 years ago

I went ahead and made those fixes, but I'm not sure what exact contributing workflow is.

I don't use leiningen (been sticking with tools.deps), after installing it and trying to run tests - ran into issues because clojure and clojurescript were not in dependencies array.

After getting tests to run, I couldn't get the actual tests to pass/fail locally. Might have to do with the fact that prop-test is a cljc file and the cljs version of tests run with a different command?

Either way, if you could add contribution docs that clarify necessary steps that would be great.

edit: didn't realize you had CI setup, i'll try and follow the steps there

lilactown commented 4 years ago

That's good feedback, I'll work on a document that lays out contribution guidelines and setup.

The workflow I typically use is to boot up shadow-cljs and connect my editor to it. There, I can run CLJ tests from the Clojure REPL.

To run the CLJS tests, I run the :test build and navigate to http://localhost:8021 that has the test runner UI, which hot reloads on changes.

This way, I can evaluate Clojure tests from the REPL and hot reload ClojureScript tests in the browser.

Hope that helps! Like I said, I'll do some work on cleaning up this workflow and documenting it since I would like it make it easier for people to contribute. Thanks again for the fix!

lilactown commented 4 years ago

Looks great!