search

lilactown / punk

A data REBL built for the web
Eclipse Public License 2.0
148 stars 5 forks source link

Drops consecutive taps #10

Closed lilactown closed 5 years ago

lilactown commented 5 years ago

This is probably due to core.async channel buffer size.

Per thheller:

thheller [1:30 PM]
try to use `(when-not (async/offer! the-chan value) (js/console.log "failed to put val" value))`

then `async/offer!` returns false the buffer was full

We actually need to ensure that we handle back pressure effectively; we can't be sure a user will put a tap> in a hot loop that just floods the core.async channel and/or websocket with messages.

lilactown commented 5 years ago

Actually, it was a parse error; closing this for now.