lilactown / punk

A data REBL built for the web
Eclipse Public License 2.0
148 stars 5 forks source link

punk in pink-gorilla notebook #20

Open awb99 opened 4 years ago

awb99 commented 4 years ago

Hi! I really like your project! It is the only clojurescript project, that one could use out of the box. I have adapted punk for pink-gorilla notebook.

To do this I added a nrepl-op to nrepl middleware (https://github.com/pink-gorilla/nrepl-middleware/commit/21f032d73387928e9dc8917368d552de8a44dd96) In notebook ui I converted the punk ui to ordinary reframe (as I could not find out how the frame stuff works, and was not sure if it will not make issues with reagent) https://github.com/pink-gorilla/notebook-ui/pull/2

In case anyone is interested:

in nrepl middleware:
lein relay

In notebook.ui
lein demo

URL is at:
http://localhost:8004/demo/save

I am pretty excited, as the scope for more features is big:

What I had problems with are EDN encodings, and they are needed by nav (the value parameter). I had to add a dirty hack to solve that.

awb99 commented 4 years ago

My ideas to integrate this well in gorilla-notebook is to add datafy links inside the notebook, and then open a datafy dialog that does only show the entries of the selected notebook segment. This saves one step in the navigation.