Open awb99 opened 4 years ago
My ideas to integrate this well in gorilla-notebook is to add datafy links inside the notebook, and then open a datafy dialog that does only show the entries of the selected notebook segment. This saves one step in the navigation.
Hi! I really like your project! It is the only clojurescript project, that one could use out of the box. I have adapted punk for pink-gorilla notebook.
To do this I added a nrepl-op to nrepl middleware (https://github.com/pink-gorilla/nrepl-middleware/commit/21f032d73387928e9dc8917368d552de8a44dd96) In notebook ui I converted the punk ui to ordinary reframe (as I could not find out how the frame stuff works, and was not sure if it will not make issues with reagent) https://github.com/pink-gorilla/notebook-ui/pull/2
In case anyone is interested:
I am pretty excited, as the scope for more features is big:
What I had problems with are EDN encodings, and they are needed by nav (the value parameter). I had to add a dirty hack to solve that.