Update opentracing & openzipkin w/ contrib repo

lileio / pubsub

A Publish & Subscribe library, with pluggable providers and middleware for Golang

MIT License

137 stars 23 forks source link

Closed oz closed 4 years ago

oz commented 5 years ago

This updates both dependencies:

for opentracing, it allows us to use the recent-ish mock structs in tests.
for openzipkin, this switches to the contrib repository, as the old one is no longer used.

I wish I could make 2 PRs, but the two are kind of intertwined right now.

Hope this helps!

arbarlow commented 5 years ago

Really sorry I didn't see this @oz, CI is failing but I'll sort that today and we'll get this merged

arbarlow commented 5 years ago

hi @oz, this is ready,. but I'll need you to resolve some conflicts first?

oz commented 5 years ago

I rebased the PR on top of master.

Hope this helps!

jesushernandez commented 4 years ago

@oz Hey, I was about to do exactly what you're doing here. Do you mind rebasing again (sorry)? I'll make sure it's merged promptly this time 👍

jesushernandez commented 4 years ago

@oz Hey! We've proactively taken your work and merged into master now. Thanks a lot for your help :)

oz commented 4 years ago

I just got the notification, was offline for a good while.

Thanks for merging that. :+1: