search

lileio / pubsub

A Publish & Subscribe library, with pluggable providers and middleware for Golang
MIT License
137 stars 23 forks source link

Make sure we handle non-errors #29

Closed jesushernandez closed 2 years ago

jesushernandez commented 2 years ago

At the moment, if a subscriber panics with eg: panic("foo"), it'll bring the whole service down (when the subscriber is part of a service), since the recover middleware will panic here https://github.com/lileio/pubsub/blob/master/middleware/recover/recover.go#L46 (invalid interface conversion)

arbarlow commented 2 years ago

Thanks! Merged

jesushernandez commented 2 years ago

@arbarlow cheers! Should we create a new tag? To avoid those autogenerated version hashes when doing @latest

arbarlow commented 2 years ago

Sure

arbarlow commented 2 years ago

v2.6.0 now minted