search

lili21 / critical-css-webpack-plugin

9 stars 4 forks source link

Missing CSS -- not a problem with webpack-critical-plugin #2

Closed GeorgeTaveras1231 closed 6 years ago

GeorgeTaveras1231 commented 6 years ago

I was experiencing a flash of unstyled content while using this plugin. There was some extracted CSS but seems like the calculation of the critical path CSS was slightly off.

After switching back to webpack-critical-plugin, saw that the problem went away. I don't have the time right now to create a reproduction repository but I can probably assist some time in the near future (1 week from now if necessary).

Here is a diff of the generated critical css:

On the right side is what is generated by webpack-critical-plugin https://www.diffchecker.com/sLKcafIF

GeorgeTaveras1231 commented 6 years ago

Looked further into this, seems like the problem is in the critical package. Any version after 1.0.0 introduces this problem for me