search

lilianweng / stock-rnn

Predict stock market prices using RNN model with multilayer LSTM cells + optional multi-stock embeddings.
https://lilianweng.github.io/lil-log
1.75k stars 659 forks source link

Embedding configured incorrectly #6

Closed ssatia closed 6 years ago

ssatia commented 6 years ago

self. inputs_with_embed holds the embeddings concatenated with self.inputs. However, the embeddings are not being used since the RRN is still using self.inputs:

https://github.com/lilianweng/stock-rnn/blob/aa03e93fb0cf55990c2fb64d52902bb98186eed5/model_rnn.py#L102

lilianweng commented 6 years ago

You are totally right. The issue has been fixed in commit 084707d :)

Thanks!