lilidan / gyp

Automatically exported from code.google.com/p/gyp
0 stars 0 forks source link

Analyzer doesn't deal with static library dependencies correctly #493

Closed GoogleCodeExporter closed 9 years ago

GoogleCodeExporter commented 9 years ago
The problematic build is here:

http://build.chromium.org/p/tryserver.chromium.mac/builders/ios_rel_device_ninja
/builds/74467/steps/analyze/logs/stdio

The problematic case can be reduced to the following:
Target A depends on target B.  Both are static libraries. B has a source file 
boo.cc. If the changed file is boo.cc then analyzer outputs A as it assumes the 
dependency of A on B results in B getting built. This is wrong. If a static 
library depends upon another static library the dependency is not a compile 
time dependency. Meaning in this case B and boo.cc are not built and was the 
result of the build breakage when the patch landed on the waterfall.

Original issue reported on code.google.com by sky@chromium.org on 8 Jun 2015 at 3:47

GoogleCodeExporter commented 9 years ago
Should be fixed here: 
https://chromium.googlesource.com/external/gyp/+/fdc7b812f99e48c00e9a487bd56751b
beae07043 .

Original comment by sky@chromium.org on 8 Jun 2015 at 6:28

GoogleCodeExporter commented 9 years ago

Original comment by scottmg@chromium.org on 9 Jun 2015 at 9:04