search

lillik / magento2-price-decimal

Magento 2 Extension: Price Decimal Precision
Apache License 2.0
109 stars 68 forks source link

2.4.5 support #81

Closed npluimers closed 1 year ago

verhaeghep commented 1 year ago

The function formatPriceLocale is copied from original Magento2 source code. Don't see any reason to change this. https://github.com/magento/magento2/blob/2.4.5-p1/app/code/Magento/Catalog/view/base/web/js/price-utils.js

npluimers commented 1 year ago

While the function is indeed from magento 2 source, I have made the change suggested 👍

WaPoNe commented 1 year ago

@lillik could you accept this PR, please? Changes are made by @npluimers

I think it will be the best solution to create a new tag (2.0.0 ?) putting in also this accepted PR https://github.com/lillik/magento2-price-decimal/pull/73 (it is not in 1.0.8 tag)

lillik commented 1 year ago

Need to fix code conflicts.

WaPoNe commented 1 year ago

@npluimers could you add code I suggested and fix code conflicts?

Thank you.

verhaeghep commented 1 year ago

Why does it take so long to fix this?

pfortin-expertime commented 1 year ago

@verhaeghep you can use my fork for the time being : "pfortin-expertime/magento2-price-decimal": "1.0.9"

But I don't want to steal the work from @lillik so as soon we will have a new version compatible with 2.4 I'll remove it.

kasperth commented 1 year ago

@lillik Any progress on this? Appreciate the good work!

bertholdkremser commented 1 year ago

@lillik Any progress on this? Would love to see this fixed. Appreciate the good work!

lillik commented 1 year ago

@kasperth @bertholdkremser I appreciate your work. The PR was merged.