search

lilserf / bot-on-the-clocktower

Bot to assist with playing Blood on the Clocktower via Discord
MIT License
22 stars 4 forks source link

ClearOverrides on night Cottages makes them entirely public #150

Closed magroader closed 2 years ago

magroader commented 2 years ago

As found in #147, the ClearOverrides call can actually clears ALL overrides on a cottage, including the one granted by being in the Night category. This means the cottage can become 100% public, which is bad!

magroader commented 2 years ago

I have temporarily disabled that feature entirely to avoid this

magroader commented 2 years ago

According to Steini this may be because the Cottages in question already had manual adjustments for a different role.

It sounds like in order to properly support this feature, we need to be more surgical in our permissions adjustments. We should probably get all the overrides, remove any that exist for players in the game other than the one slated for that cottage (if any), add a new ones for the player going to that cottage (if needed), and that's it.