Build with cargo - Githubissues

lilyball / rust-lua

Safe Rust bindings to Lua 5.1

MIT License

127 stars 23 forks source link

Build with cargo #6

Closed beatgammit closed 10 years ago

beatgammit commented 10 years ago

move all source files to src/
ignore target/ and Cargo.lock
issue #5

This works for me on Linux, but I haven't tested on any other platform.

beatgammit commented 10 years ago

I added in a fix for the latest nightly. If you'd prefer for it to be on a separate PR, let me know and I'll separate them.

beatgammit commented 10 years ago

I added in a minor change to the allow attribute to cut down on warnings.

The latest commit does bring up a question though: should the bindings match the lua bindings in terms of casing, or should it follow rust style?

lilyball commented 10 years ago

Sorry I haven't gotten to this yet. Been very busy. I'll try to take a look soon.

As for name style, I've been trying to match the existing Lua bindings as much as I can, for familiarity and ease in porting. If you're reading documentation on the Lua C APIs, it should be easy to figure out what the equivalent Rust API is.

beatgammit commented 10 years ago

Sorry I haven't gotten to this yet. Been very busy. I'll try to take a look soon.

That's fine, I understand. If you like, I can move the commits that aren't directly related to a separate PR since they just fix a compile error and hide some warnings.

beatgammit commented 10 years ago

I broke this up into smaller pieces, so this PR now only makes changes to support building with cargo.

See #7 for the changes that fix the tests.

beatgammit commented 10 years ago

Closing in favor of #9.