search

lilybeevee / bab-be-u

Love2D silly fangame of Baba Is You
https://bab-devs.github.io/
MIT License
144 stars 38 forks source link

Anti false/anti true + unit.blocked instead of parse_rule = false (or something like this) #152

Closed Dzhake closed 1 year ago

Dzhake commented 1 year ago

so uhhh title? i hope you can understand everything lol. i think you should look in game/scene.lua line about 1350? false and true code there. Also you can remake them as fols and tru so they won't conflict with lua's ones.

Dzhake commented 1 year ago

This is only for my mod, correct? if no, then i will combine all my known bugs in one pull request.

Adrthegamedev commented 1 year ago

You've done, uh, a lot more than what the title says, including adding way too much sprites, overwriting the readme file, and breaking the obscure inbuilt mod support. yeah no way this is getting merged in its current state

Dzhake commented 1 year ago

uhhh i don't wanna make this merged? Also, what is wrong with overwriting readme file? And why way too much sprites? Yeah, i know about inbuilt mod support, but i didn't like it, so i made my own mod support

Dzhake commented 1 year ago

Looks like idk what is pull request lol.

Dzhake commented 1 year ago

I thought it's like: "this is bugged, i should fix it. Maybe you know how to fix it? pls help me."

Dzhake commented 1 year ago

Maybe i should use "issues" tab? hm..

Adrthegamedev commented 1 year ago

uhhh i don't wanna make this merged?

Then why make a pull request to begin with? Pull requests are for things you want to be merged into the original repository.

Adrthegamedev commented 1 year ago

Maybe i should use "issues" tab? hm..

No, the issues tab is for issues in the regular codebase, not any modded ones.