Closed trathborne closed 2 years ago
There is a conflict here now. Could you resolve it?
I resolved the conflict and handled the cases of only one of oldver/newver being None, though I'm not sure all of those will ever happen. This is a bit more change than I wanted just to add --all
but I think distinguishing all of these cases could be useful for automation using nvchecker.
Hmm, and maybe the part at the end which picks the arrow symbol and the color could be a dictionary lookup?
The updated code doesn't look right. It always shows all versions and with a ==
symbol.
which picks the arrow symbol and the color could be a dictionary lookup?
Yes, it'll look better.
Haha it's a typo, if
in the middle of the if..elif..elif..if..elif
... dictionary version coming right up!
Dammit still buggy
Ok now I think that's right. My mistake for coding before coffee!
mypy is being pedantic. We know that the diff is going to have a 'delta'. Should that be diffstyles[diff.get('delta', 'equal')]
to make mypy shut up?
Any idea what will make mypy happy?
When I can't make mypy happy and am sure my code is correct, I just tell mypy to shut up :-)
It's also useful to be able to report packages without a changed version!
Now displaying both versions in green with == instead of an arrow.