search

lilydjwg / nvchecker

New version checker for software releases
MIT License
439 stars 70 forks source link

Newer version of python-gobject breaks nvchecker-notify script #217

Closed inglor closed 2 years ago

inglor commented 2 years ago

The newer version of python-gobject breaks the notify script:

nvchecker-notify -c ~/workspace/pkgbuild-super/nvchecker.toml
Traceback (most recent call last):
  File "/usr/bin/nvchecker-notify", line 14, in <module>
    gi.require_version('Notify', '0.7')
  File "/usr/lib/python3.10/site-packages/gi/__init__.py", line 129, in require_version
    raise ValueError('Namespace %s not available for version %s' %
ValueError: Namespace Notify not available for version 0.7

As per @yan12125 suggestion something like this would fix this (already tested it locally) https://gitlab.gnome.org/GNOME/gnome-tweaks/-/merge_requests/99/diffs

lilydjwg commented 2 years ago

Thanks!

yan12125 commented 2 years ago

Thanks a lot for the fast fix! I cherry-picked it to the Arch Linux package.

yan12125 commented 2 years ago

Hmm, a libnotify dev is considering reverting the version back to 0.7 (https://gitlab.gnome.org/GNOME/libnotify/-/issues/27#note_1503676)

Just hardcode MODULE_VERSION to 0.7 until the project breaks API.

inglor commented 2 years ago

Oh well, the fix in place will work either way ;)