search

lilydjwg / nvchecker

New version checker for software releases
MIT License
428 stars 69 forks source link

feat(tools): handle symlinks correctly for take command #240

Closed Segaja closed 11 months ago

Segaja commented 11 months ago

This will make nvtake preserve symlinks of the "old" configfile

lilydjwg commented 11 months ago

What about only use shutil.copy if oldverf is a symlink?

Segaja commented 11 months ago

What about only use shutil.copy if oldverf is a symlink?

That is doable, but what is the advantage? I think the end result would be for both cases the same and it only makes the code more complex, right?

lilydjwg commented 11 months ago

That is doable, but what is the advantage?

Avoid a file copy. It's not a large file indeed, but it's also not a lot of code.

Segaja commented 11 months ago

That is doable, but what is the advantage?

Avoid a file copy. It's not a large file indeed, but it's also not a lot of code.

I updated the Pull Request.