lilydjwg / pssh

Parallel SSH Tools
Other
284 stars 64 forks source link

diff of prsync to take "--exclude" and "--exclude-from" switch #54

Closed GoogleCodeExporter closed 8 years ago

GoogleCodeExporter commented 8 years ago
Request for enhancement. For those who need "--exclude" and "--exclude-from" 
options.

pssh            - 2.2.2        - active

diff /opt/python-2.5.4/bin/prsync.ori /opt/python-2.5.4/bin/prsync
33a34,37
>     parser.add_option('-e', '--exclude', metavar="ARGS", dest='exclude',
>             action='store', help='Exclude from rsync (OPTIONAL)')
>     parser.add_option('-E', '--excludefrom', metavar="FILE", 
dest='excludefrom',
>             action='store', help='Exclude from rsync based on defined files 
(OPTIONAL)')
87a92,95
>         if opts.exclude:
>             cmd.append('--exclude=%s' % opts.exclude)
>         if opts.excludefrom:
>             cmd.append('--exclude-from=%s' % opts.excludefrom)

Original issue reported on code.google.com by che.t...@gmail.com on 19 Aug 2011 at 10:44

GoogleCodeExporter commented 8 years ago
Have you considered using the -x (or -X) option?  In general, we prefer to use 
these when they work because otherwise we'd have to duplicate all of the 
(thousands?) of rsync command-line options.  Thanks.

Original comment by amcna...@gmail.com on 20 Aug 2011 at 5:45

GoogleCodeExporter commented 8 years ago
doh, didn't see that switch. Ticket can be closed. 

Original comment by che.t...@gmail.com on 22 Aug 2011 at 9:10

GoogleCodeExporter commented 8 years ago
No problem.  Let me know if you can think of any way to make this option more 
visible.  It seems to be a common need, and I've tried adding some examples to 
the man page, but I think it's not quite enough.

Thanks for your participation with pssh.

Original comment by amcna...@gmail.com on 22 Aug 2011 at 9:49

GoogleCodeExporter commented 8 years ago
It was an oversight on my part. I didn't read the examples thoroughly.

Thanks for the quick response.

Great program by the way. Sure speed things up for us.

Original comment by che.t...@gmail.com on 23 Aug 2011 at 1:57