Discussion

[RAVENz46]

Thanks for your work! I tried this module and I think it need some modifications but I'm still newbie and other people also may want some modification, so I create this.

Anyway I think it is better to

• [x] add services.gvfs.enable = true; (and remove security.polkit.enable = true; cause it is included?) 1914ef3d3bbbf79892b48e9162b47f64ff99bcd5
• [x] add services.xserver.updateDbusEnvironment = true;

and we have to discuss about

• [x] use pipewire default instead of pulse audio or not 413848ef7d198b54714de618aa7a4c1c4bb67edd
• [x] add services.power-profiles-daemon.enable = mkDefault true; (it will available in the future) or not 0aa2a04a84725f26f6b633f64b3867a7ce77864d
• [x] add programs.dconf.enable = true; or not 803fb65f051bbff9434ade697aa0efc6bda6e3ff
• [ ] add services.colord.enable = true; or not
• [x] add networking.networkmanager.enable = mkDefault true; or not 1914ef3d3bbbf79892b48e9162b47f64ff99bcd5
• [ ] add environment.pathsToLink = [ "/share" ]; or not (described here)
• [ ] add programs.system-config-printer.enable = (mkIf config.services.printing.enable (mkDefault true)); or not
• [ ] add services.fwupd.enable = true; or not
• [x] rename option services.xserver.desktopManager.cosmic to services.desktopManager.cosmic like plasma6 module did or not 9332bcd6ba4f2678c5b9434e7fa5a021ee3b64d8

[lilyinstarlight]

I'm gonna number these to make it easy:

1. Does cosmic-files do GVFS? I do agree it should probably be enabled, though (I'm gonna keep polkit though to be explicit rather than implicit)
2. Does that affect anything for non-X servers? I thought about adding it, but I couldn't tell that it did anything when not using Xorg

Discuss:

1. I would not be opposed, but I would probably follow what Pop does there (and I haven't looked it up)
2. We probably should enable PPD yeah if it's gonna use it (otherwise was considering sys76-power)
3. Does COSMIC use dconf anywhere? It may be useful for GNOME-y user apps though
4. That's probably not a bad idea. I'll research what colord does more
5. Yes, we should probably do NM by default (I was kinda waiting for it to be implemented in cosmic-settings/applets)
6. I'll need to research that one more
7. We probably should if it does something for COSMIC
8. I planned to add that when cosmic-settings get fwupd support or see if it gets implemented via something else
9. The plasma6 module rename was incomplete (e.g. references weren't updated and it's not been updated for displayManager options yet either) and tbh we should move way more options about that instead of doing it DE-by-DE

Thank you for bringing these up! :)

[RAVENz46]

Does that affect anything for non-X servers? I thought about adding it, but I couldn't tell that it did anything when not using Xorg

cosmic requires dbus as dependencies so I think it needs for xwayland probably...? Sorry I'm not sure so I have to figure it out.

We probably should enable PPD yeah if it's gonna use it (otherwise was considering sys76-power)

I see. It looks like it is better to wait until they implement this feature.

Does COSMIC use dconf anywhere? It may be useful for GNOME-y user apps though

Probably not. But even plasma module enables it, so it is not too bad I think.

Anyway, I'll wait patiently cause it's too early to decide some stuffs. Thanks!

[lilyinstarlight]

I've gone ahead and added dconf, renamed the cosmic options to be outside of xserver, and double checked that updateDbusEnvironment will do nothing for COSMIC (it only affects environments that use services.xserver.displayManager.session (which generate start scripts and .desktop files for environments that have none) and only for Xorg sessions (not wayland sessions, even with Xwayland))

[KaiserCalm]

In the latest blogpost, it is mentioned that support for gvfs was added and that now it is used for usb drive and network drive mounts.

[lilyinstarlight]

I've enabled GVFS and NetworkManager in the module by default now