lilyinstarlight / zmk-nix

Build system and configuration files for generating and building ZMK firmware with Nix
MIT License
68 stars 18 forks source link

Add comment explaining why `make-fake-west-git` is necessary? #79

Open hab25 opened 4 months ago

hab25 commented 4 months ago

I.e., right above https://github.com/lilyinstarlight/zmk-nix/blob/829adef3fb59b152be10cef6b733124ba6c7882f/nix/zephyr/fetcher.nix#L27.

Even more importantly than helping maintenance of this project, after this is done, we could probably point the west maintainers to it so they could better consider adding a feature that obviates the need for this workaround. Then, by implementing that feature, this project would become more resistant to change because it would be relying on less fragile assumptions.

PS: Thanks a lot for this, it works flawlessly.