lilyinstarlight / zmk-nix

Build system and configuration files for generating and building ZMK firmware with Nix
MIT License
68 stars 18 forks source link

Broken maintainer reference #99

Closed alejandro-angulo closed 3 months ago

alejandro-angulo commented 3 months ago

First off, really glad this flake exists. It works fine but I noticed I was seeing errors when trying to build the packages as part of a hydra job. lilyinstarlight removed herself as a maintainer in nixpkgs (see this PR https://github.com/NixOS/nixpkgs/pull/323903) and now I see this output

in job ‘packages.flash’:
error: undefined variable 'lilyinstarlight'
       at /nix/store/cqc4xqcy5c4ix2zkknfp1ngz3vm2qi12-source/nix/flash.nix:81:39:
           80|     platforms = platforms.linux;
           81|     maintainers = with maintainers; [ lilyinstarlight ];
             |                                       ^
           82|   };

in job ‘packages.update’:
error: undefined variable 'lilyinstarlight'
       at /nix/store/cqc4xqcy5c4ix2zkknfp1ngz3vm2qi12-source/nix/update.nix:74:39:
           73|     platforms = platforms.all;
           74|     maintainers = with maintainers; [ lilyinstarlight ];
             |                                       ^
           75|   };
alejandro-angulo commented 3 months ago

Oh wow, right as I made this issue I saw @lilyinstarlight added commit 2d5ea4b2c8d138824024fb8061a31bc28110b09b to address this :sweat_smile:

lilyinstarlight commented 3 months ago

Haha, yep! Thanks for the report regardless :)